refactor(ci): Pipeline yml cleanup #23412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (15)
- tools/pipelines/templates/include-set-package-version.yml: Evaluated as low risk
- tools/pipelines/templates/include-test-perf-benchmarks.yml: Evaluated as low risk
- tools/pipelines/build-build-common.yml: Evaluated as low risk
- tools/pipelines/build-build-tools.yml: Evaluated as low risk
- tools/pipelines/build-client.yml: Evaluated as low risk
- tools/pipelines/build-common-utils.yml: Evaluated as low risk
- tools/pipelines/templates/include-test-real-service.yml: Evaluated as low risk
- tools/pipelines/templates/include-telemetry-setup.yml: Evaluated as low risk
- tools/pipelines/templates/include-test-stability.yml: Evaluated as low risk
- tools/pipelines/build-benchmark-tool.yml: Evaluated as low risk
- tools/pipelines/build-api-markdown-documenter.yml: Evaluated as low risk
- tools/pipelines/templates/include-publish-npm-package-deployment.yml: Evaluated as low risk
- tools/pipelines/templates/build-docker-service.yml: Evaluated as low risk
- tools/pipelines/build-protocol-definitions.yml: Evaluated as low risk
- tools/pipelines/build-test-tools.yml: Evaluated as low risk
|
@microsoft-github-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up a few things we had noticed in our yml files.
releaseBuildVar,componentDetection) were not used anymore (if anything only printed, but not used for any functional purpose).include-policy-check.ymlwas not included as a PR/CI trigger for many build pipelines that depend onbuild-npm-package.yml(which in turn depends oninclude-policy-check.yml).buildNumberInPatchfrom a string to a boolean, like it could have been from the start, and gave it a default to avoid passing an empty string explicitly in several pipelines. Its value ends up as VERSION_PATCH here, and that flag gets checked against"true". So replacing with a boolean should be fineReviewer Guidance
The review process is outlined on this wiki page.
AB#6994