Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove line rate comparison for code coverage as that is not much useful due to comments #23389

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove line rate comparison for code coverage as that is not much useful due to comments #23389

wants to merge 3 commits into from
+55 −24

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Dec 20, 2024 •
edited
Loading

Description

AB#23400
Based on the feedback and analysis we are removing line rate comparison for code coverage as that is not much useful due to comments increasing and decreasing it based on whether the comments was in covered code or non-covered code.

@jatgarg jatgarg requested a review from alexvy86 December 20, 2024 20:03
@jatgarg jatgarg self-assigned this Dec 20, 2024
@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 20:03
@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Dec 20, 2024
Copilot
Copilot AI reviewed Dec 20, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
alexvy86
alexvy86 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit looks fine. I suggest that we either remove the properties related to line coverage from CodeCoverageComparison or add notes to them saying we deliberately don't use them.

@github-actions github-actions bot added the area: loader Loader related issues label Dec 20, 2024
jatgarg
jatgarg commented Dec 20, 2024
View reviewed changes
Copy link
Contributor Author

@jatgarg jatgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

No packages impacted by the change.

Baseline commit: 77bc641
Baseline build: 313850
Happy Coding!!

Code coverage comparison check passed!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@alexvy86 alexvy86 alexvy86 approved these changes

Assignees

@jatgarg jatgarg

Labels
area: build Build related issues area: loader Loader related issues base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatgarg @alexvy86