Abstract customdataRetriever in historian, pass simplified customData to gitrest filesystem #23354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
zhajie
changed the title
There was a problem hiding this comment.
Copilot reviewed 6 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (15)
- server/historian/packages/historian-base/src/routes/summaries.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/app.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/repository/commits.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/git/trees.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/repository/headers.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/repository/contents.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/git/blobs.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/runner.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/git/tags.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/runnerFactory.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/git/refs.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/git/commits.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/routes/utils.ts: Evaluated as low risk
- server/historian/packages/historian-base/src/services/index.ts: Evaluated as low risk
- server/gitrest/packages/gitrest-base/src/utils/helpers.ts: Evaluated as low risk
znewton
reviewed
Dec 20, 2024
yunho-microsoft
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to abstract customdataRetriever in historian and passing simplifiedCustomData to gitrest.
Background:
Blob container per doc is a storage optimization for FRS Durable Container. In container per doc mode, the document vs azure blob container is 1:1 mapping. The blob container was created before the initial summary uploaded.
To support a cmk-related case in containerPerDoc mode, there is specific tenant-level info needs to be read from tenantDB, and passed to storage layer in document creation flow. In oss, just wrap this info as a generic message, and pass it all the way into filesystemFactory parameters without editing, in this way most of implementation details specific to this case can be contained in FRS.
Main Changes:
In historian, abstract an interface ISimplifiedCustomDataRetriever.get() to convert customData to a simple string (customized implementation in FRS), then pass to gitrest via http header.
In gitrest, get SimplifiedCustomData from header and add as part of FileSystemManagerFactory parameter.