Copy npmrc in dockerfile #23330
Open
Copy npmrc in dockerfile #23330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- server/gitrest/Dockerfile: Language not supported
- server/historian/Dockerfile: Language not supported
- server/routerlicious/Dockerfile: Language not supported
github-actions
bot
added
area: server
Abe27342
approved these changes
Dec 13, 2024
|
This is failing due to frozen lock files. This is implying that the pnpm install in the docker container is installing different packages than the ones in our lock files which means those versions are not getting audited and tested. This should be fixed to unblock this change. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently settings like:
Are not applied to our docker containers due to them coming from npmrc which is not copied. This fixes that, making them more strict.
AB#26779
Reviewer Guidance
The review process is outlined on this wiki page.