-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(telemetry-utlis): Make MockLogger internal #23010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↓ packages.utils.telemetry-utils.src:
Line Coverage Change: -0.04% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 94.79% | 94.79% | → No change |
Line Coverage | 92.98% | 92.94% | ↓ -0.04% |
Baseline commit: b70e394
Baseline build: 304760
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: b70e394 |
7fd69f9
to
9c0ff0c
Compare
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, where does the filename green-readers-burn.md
come from? Is it randomly generated and these release notes all just get aggregated at release time? Or does the name have some meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Randomly generated. Running pnpm changeset
from the root of the repo starts a wizard that takes care of that, and just prompts for the package(s) with changes, the "category" of change (like "legacy" in this case; technically free-form, but the ones we use are configured here and a value outside that list will cause the release note generation process to complain), a title, and a longer description. You could copy-paste an existing changeset file and give it any name, it doesn't matter in the end as long as they're unique.
Then we have a flub generate releaseNotes
(src) command that takes the changesets and produces the compiled release notes. It runs continuously to produce a preview of the upcoming release notes here (always in that issue).
Still have to check for uses of this class in partner repos before merging, I'll merge once I'm comfortable about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Reverts #23010. Since it wasn't part of the list of removals for 2.10, holding this until 2.20.
Description
Removes the
MockLogger
class from the@alpha+@legacy
API surface. It has been deprecated for external use since 2024-06-18.Breaking Changes
MockLogger
is now removed from the@alpha+@legacy
API surface, becoming only@internal
.Reviewer Guidance
The review process is outlined on this wiki page.
AB#22886