Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(telemetry-utlis): Make MockLogger internal #23010

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Nov 6, 2024

Description

Removes the MockLogger class from the @alpha+@legacy API surface. It has been deprecated for external use since 2024-06-18.

Breaking Changes

  • MockLogger is now removed from the @alpha+@legacy API surface, becoming only @internal.

Reviewer Guidance

The review process is outlined on this wiki page.

AB#22886

@github-actions github-actions bot added changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↓ packages.utils.telemetry-utils.src:
Line Coverage Change: -0.04%    Branch Coverage Change: No change
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 94.79% 94.79% → No change
Line Coverage 92.98% 92.94% ↓ -0.04%

Baseline commit: b70e394
Baseline build: 304760
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 6, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 464.03 KB 464.06 KB +35 Bytes
azureClient.js 562.45 KB 562.49 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 261.86 KB 261.87 KB +14 Bytes
fluidFramework.js 424.82 KB 424.84 KB +14 Bytes
loader.js 134.17 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 148.54 KB 148.55 KB +7 Bytes
odspClient.js 528.29 KB 528.34 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 164.58 KB 164.58 KB +7 Bytes
sharedTree.js 415.28 KB 415.29 KB +7 Bytes
Total Size 3.36 MB 3.36 MB +245 Bytes

Baseline commit: b70e394

Generated by 🚫 dangerJS against 9c0ff0c

@alexvy86 alexvy86 force-pushed the make-mocklogger-internal branch from 7fd69f9 to 9c0ff0c Compare November 7, 2024 01:03
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/start/tree-start/
- (3430:89) 'here' => https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/docs/main/merge-semantics.md (HTTP 404)


Stats:
  446344 links
    3431 destination URLs
       2 URLs ignored
       0 warnings
       1 errors

 ELIFECYCLE  Command failed with exit code 1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, where does the filename green-readers-burn.md come from? Is it randomly generated and these release notes all just get aggregated at release time? Or does the name have some meaning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Randomly generated. Running pnpm changeset from the root of the repo starts a wizard that takes care of that, and just prompts for the package(s) with changes, the "category" of change (like "legacy" in this case; technically free-form, but the ones we use are configured here and a value outside that list will cause the release note generation process to complain), a title, and a longer description. You could copy-paste an existing changeset file and give it any name, it doesn't matter in the end as long as they're unique.

Then we have a flub generate releaseNotes (src) command that takes the changesets and produces the compiled release notes. It runs continuously to produce a preview of the upcoming release notes here (always in that issue).

@alexvy86
Copy link
Contributor Author

alexvy86 commented Nov 7, 2024

Still have to check for uses of this class in partner repos before merging, I'll merge once I'm comfortable about that.

@alexvy86 alexvy86 marked this pull request as ready for review November 8, 2024 00:23
@alexvy86 alexvy86 requested review from a team as code owners November 8, 2024 00:23
Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@alexvy86 alexvy86 merged commit 32ff6b9 into microsoft:main Nov 8, 2024
36 checks passed
@alexvy86 alexvy86 deleted the make-mocklogger-internal branch November 8, 2024 17:38
alexvy86 added a commit that referenced this pull request Nov 8, 2024
alexvy86 added a commit that referenced this pull request Nov 11, 2024
Reverts #23010.

Since it wasn't part of the list of removals for 2.10, holding this
until 2.20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants