Shared tree/rebaser telemetry #21154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
seanimam
reviewed
May 22, 2024
| @@ -173,6 +181,14 @@ export function rebaseBranch<TChange>( | |||
| findCommonAncestor(targetCommit, targetHead) !== undefined, | |||
| 0x676 /* target commit is not in target branch */, | |||
| ); | |||
|
|
|||
| logger?.sendTelemetryEvent({ | |||
There was a problem hiding this comment.
Have you considered using logger?.sendPerformanceEvent(..) instead? It seems like a good fit given the type of telemetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADO 5141
This PR creates telemetry loggers for the
SharedTreeDDS which emit telemetry events for rebase operations of below scenarios:The event will include:
Note: Instead of logging the event for every rebase operation, we should log events in batch (e.g., every 100 operations).