Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary docs #10495

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Summary docs #10495

merged 4 commits into from
Jun 2, 2022

Conversation

tylerbutler
Copy link
Member

Merging #10435 into the next branch.

@NicholasCouri
Summary docs (#10435)
234f450 
Update Summary documentation to better describe parameters and returned types.
@github-actions github-actions bot added area: runtime Runtime related issues public api change Changes to a public API base: next PRs targeted against next branch labels Jun 1, 2022
@NicholasCouri
Draft: Temporarily add an empty .commits to the snapshots to support … (
17d3d18 
#10429) (#10484)

* Draft: Temporarily add an empty .commits to the snapshots to support backward compatibility (#10414)
@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver labels Jun 1, 2022
@github-actions github-actions bot added the area: server Server related issues (routerlicious) label Jun 1, 2022
@tylerbutler tylerbutler marked this pull request as ready for review June 1, 2022 22:51
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners June 1, 2022 22:51
@tylerbutler
Copy link
Member Author

tylerbutler commented Jun 1, 2022 •
edited by NicholasCouri
Loading

@NicholasCouri Im merging your main branch change to the next branch. Can you please do a sanity check and approve if things look good? The CI is already passing.

In reply to: 1144220966

@NicholasCouri
Copy link
Contributor

NicholasCouri commented Jun 1, 2022 •
edited
Loading

@NicholasCouri Im merging your main branch change to the next branch. Can you please do a sanity check and approve if things look good? The CI is already passing.

Looks fine! Thank you so much Tyler!

In reply to: 1144223512

@NicholasCouri NicholasCouri self-requested a review June 1, 2022 22:57
NicholasCouri
NicholasCouri approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@NicholasCouri NicholasCouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tylerbutler tylerbutler merged commit 672bcaa into next Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasCouri NicholasCouri NicholasCouri approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot msfluid-bot is a code owner

Assignees
No one assigned
Labels
area: driver Driver related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) base: next PRs targeted against next branch public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerbutler @NicholasCouri @jatgarg