[PowerBI] Decouple addin settings, default "Show zoom bar" to true #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te/encimita/PBIEmbedSettings
mynjj
approved these changes
Nov 27, 2024
| @@ -411,13 +430,6 @@ function CompileSettings() { | |||
| settingsObject.background = models.BackgroundType.Transparent; | |||
| } | |||
|
|
|||
| if (_forceFitToPage) { | |||
There was a problem hiding this comment.
I get that forceFitToPage option is removed, but it wasn't removed from the obsoleted procedure. So it's technically breaking (semantically) anyone using it without the grace period.
I'm ok with breaking if you are too 😄, I'm just pointing it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Power BI Embedded control add-in currently supports a bunch of different settings that change the embed experience making it richer and more customizable.
These settings are currently controlled with the
SetSettingsadd-in function, which takes a bunch of booleans. This is of course not very readable nor very extensible.This PR cleans up the code for these settings by having a different function to set up each setting. It also flips the default for the "Show Status Bar" setting to true; this is for accessibility reasons, as full-page reports might not be accessible or "navigable" without the zoom controls.
Work Item(s)
Fixes AB#556723