-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rewrite the postinstall script #192
Merged
Kikobeats
merged 12 commits into
microlinkhq:master
from
miraclx:miraclx/dump-simple-get
Apr 12, 2024
Merged
feat!: rewrite the postinstall script #192
Kikobeats
merged 12 commits into
microlinkhq:master
from
miraclx:miraclx/dump-simple-get
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraclx
changed the title
fix: post-install should fail on error
chore: rewrite the postinstall script
Apr 12, 2024
Kikobeats
force-pushed
the
miraclx/dump-simple-get
branch
from
April 12, 2024 09:11
d685773
to
227370a
Compare
Kikobeats
force-pushed
the
miraclx/dump-simple-get
branch
from
April 12, 2024 09:12
227370a
to
56d2fda
Compare
Thanks for this @miraclx. I modified your code for using debug-logfmt instead of log since it could be controlled via environment variable (added into docs too). Also I noted we can drop a filesystem operation so I implemented the changes and dropped some unnecessary lines to make the script easier to maintain 🙂 |
Kikobeats
changed the title
chore: rewrite the postinstall script
feat!: rewrite the postinstall script
Apr 12, 2024
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off #191
Swaps out
simple-get
forfetch
, and uses streams instead of buffering the whole binary in memory.Tested with
npm
,yarn
andpnpm
, and they all hidestd{out,err}
logs from post-install scripts on install unless the run fails. You can confirm this as well.