Added Device Sync request #2621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale5000-git
reviewed
Nov 12, 2024
| @@ -28,4 +28,5 @@ public class Constants { | |||
| public static final String MICROG_PACKAGE_SIGNATURE_SHA1 = "10321bd893f69af97f7573aafe9de1dc0901f3a1"; | |||
| @Deprecated | |||
| public static final int MAX_REFERENCE_VERSION = GMS_VERSION_CODE; | |||
| public static final String GP_PACKAGE_NAME = "com.android.vending"; | |||
There was a problem hiding this comment.
Why not using VENDING_PACKAGE_NAME from here?
There was a problem hiding this comment.
Why not using
VENDING_PACKAGE_NAMEfrom here?
Just a general constant
There was a problem hiding this comment.
I didn't understand your reply.
In my opinion shouldn't there be more than one costant for "com.android.vending" and also the name GP_PACKAGE_NAME isn't intuitive.
Can't they be unified?
There was a problem hiding this comment.
VENDING_PACKAGE_NAME
OK, got it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a device information synchronization request after logging in to the account to solve the problem of missing data in some request interfaces that rely on device information.
For example, when there is no device synchronization in the /assetModuleDelivery request in #2506 , some games lack resource package data returned.