Skip to content

Commit

Permalink
Cronet: Don't bundle API for now
Browse files Browse the repository at this point in the history
Fixes #1506
  • Loading branch information
mar-v-in committed Jul 1, 2021
1 parent d8e50cb commit 3075bf1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion play-services-cronet-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ apply plugin: 'maven-publish'
apply plugin: 'signing'

dependencies {
implementation("org.microg:cronet-api:$cronetVersion")
// TODO: Embedding the API causes random crashes as the Android AOT compiler will link the native implementation to
// out API classes even if embedded by a third-party app that comes with their own API classes.
// Need to find a better way to disable AOT for Cronet. Could be by packaging cronet as it's own apk that is
// embedded in the main APK but only loaded at runtime so that the AOT compiler has no way to become active.
// implementation("org.microg:cronet-api:$cronetVersion")
implementation("org.microg:cronet-common:$cronetVersion")
implementation("org.microg:cronet-native:$cronetVersion")
}
Expand Down

0 comments on commit 3075bf1

Please sign in to comment.