Configurable Async API Test Behaviour #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need this to govern if prefix of servicename and version is added to topics/channels. some use cases require strict adherence to the spec's channel definitions
Moved class so it can be reused in async minion
# Conflicts: # webapp/src/main/java/io/github/microcks/util/asyncapi/AsyncAPIImporter.java
…messages Added configuration option to list the operation method that should result in scheduled mock messages. Depending on the use case it is desirable to only emit messages for a specific method.
…eam/microcks into feat-async-api-enhancements # Conflicts: # minions/async/src/main/java/io/github/microcks/minion/async/producer/KafkaProducerManager.java
195858
commented
Apr 8, 2021
| @@ -52,20 +52,24 @@ | |||
| <artifactId>avro</artifactId> | |||
| <version>${avro.version}</version> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
After moving the URIBuilder I had to adjust the dependencies - it required the microcks-model as well as the spring-boot-starter-web dependency to build successfully.
195858
commented
Apr 8, 2021
| import io.github.microcks.util.el.TemplateEngine; | ||
| import io.github.microcks.util.el.TemplateEngineFactory; | ||
|
|
||
| public abstract class BindingProducerManager { |
There was a problem hiding this comment.
I introduced this base class to remove duplicate code (topic string creation) and in order to simplify the ProducerManager class (the case statement switching between bindings).
There's a template method publishMessages that makes sure topic strings are created and messages are sent.
Sub-classes can extend the topic generation (see the KafkaProducer) and need to implement a publishOne() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for these changes are described in #367.
The changes are configurable, the default behaviour has not changed.
The reason for this change: an Async API spec describes the interaction between a client and a broker from the brokers point of view. Publish means "the broker publishes this to the client", subscribe means "the broker subscribes/receives messages form the client". So in order to mock the "broker" side we essentially only want to publish mock messages for the "publish" operation type.