Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: feat: chart improvements #1079

Open
wants to merge 1 commit into
base: 1.9.x
Choose a base branch
from

Conversation

guyguy333
Copy link

Description

DRAFT

Many chart improvements to better support:

  • ingress
  • services
  • extraVolumes
  • extraVolumeMounts
  • initContainers
  • extraContainers
  • image

Related issue(s)

…lumes, extraVolumeMounts, initContainers, extraContainers and image
Copy link

👋 @guyguy333

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

@guyguy333
Copy link
Author

@lbroudoux This is a draft. It needs more test and documentation. But first, would you agree with changes ? Thanks

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale State due to inactivity label Mar 12, 2024
@lbroudoux lbroudoux added keep-open Explicitily keep open and removed stale State due to inactivity labels Mar 13, 2024
@lbroudoux
Copy link
Member

Reporting this one after 1.9.0 release but still a lot of interest in it! Thnak you!

@lbroudoux
Copy link
Member

Hey @guyguy333! I had a look at it and I like how it goes!
Please go ahead if you have some time to put your ideas in place. In case you have trouble finding time, let me know and share the current status so that we'll may have split the work and set some milestones.

@lbroudoux
Copy link
Member

Hey @guyguy333,
Is it still a DRAFT or can we try integrate it? Also, could you sign the commit as per the DCO policy please?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants