Skip to content

Commit

Permalink
fix handling of integer values in string replace. Closes #29
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelkamprath committed Nov 23, 2020
1 parent a95d726 commit ccf6cf5
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,17 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed
* Corrected bug that occurred when audio bit rated was configured in JSON using an integer

## [0.4.0]
### Added
* Support for Mixcloud and DLive.
* Added support for specifying transcode profiles that can be used across multiple destination configurations.
* Add kubernetes manifests, fix nginx logging, streamline the dockerfile

### Changed
* Refactored how processes are managed within the Docker container. Migrated to `jinja2`, use `pipfile` and `supervisord`.

### Fixed
* Corrected a spelling error in the file path that the Docker image looks for the JSON configuration.
Expand Down Expand Up @@ -51,7 +60,8 @@ All notable changes to this project will be documented in this file.
* First verison!


[Unreleased]: https://github.com/michaelkamprath/multi-service-rtmp-broadcaster/compare/v0.3.1...HEAD
[Unreleased]: https://github.com/michaelkamprath/multi-service-rtmp-broadcaster/compare/v0.4.0...HEAD
[0.4.0]: https://github.com/michaelkamprath/multi-service-rtmp-broadcaster/compare/v0.3.1...v0.4.0
[0.3.1]: https://github.com/michaelkamprath/multi-service-rtmp-broadcaster/compare/v0.3.0...v0.3.1
[0.3.0]: https://github.com/michaelkamprath/multi-service-rtmp-broadcaster/compare/v0.2.0...v0.3.0
[0.2.0]: https://github.com/michaelkamprath/multi-service-rtmp-broadcaster/compare/v0.1.2...v0.2.0
8 changes: 4 additions & 4 deletions multistreaming-server/rtmp-conf-generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@ def generateTranscodeConfig(transcode_config_name, block_config, config):
):
transcode_config['audioOpts'] = RTMP_TRANSCODE_AUDIO_OPTS_CUSTOM.replace(
'%%AUDIO_BIT_RATE%%',
transcode_config_block.get(
str(transcode_config_block.get(
'audioBitRate', DEFAULT_AUDIO_OPTS['audioBitRate']
),
)),
).replace(
'%%AUDIO_SAMPLE_RATE%%',
transcode_config_block.get(
str(transcode_config_block.get(
'audioSampleRate', DEFAULT_AUDIO_OPTS['audioSampleRate']
),
)),
)
return transcode_config

Expand Down

0 comments on commit ccf6cf5

Please sign in to comment.