Add ability to dump and restore state counter from persistent database (shelve) #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #787 partially (dashboard issue) |
Closed
|
I hope this get merged once |
|
@mher , please, merge this. |
|
merge this |
|
Very soon it will be anniverasy of 5 years 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use
persistent=Trueto dump state to the file, counter data is not dumped.Therefore after restoring from the file, on dashboard we do not see any statistics, everything is 0.
To add ability to store counter along with the state,
__reduce__method was overridden and__init__to accept counter.Note: we can try to restore from
kwargsbut for these we need to create__new__constructor for EventState class and add additional magic method (as shelve is using protocol 3 by default)