Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate no comms in docker #1113

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Commits on Jun 7, 2021

  1. Add is_broker_connected function.

    This function is called now before flower.start() is called to make sure we have a working broker and starting Flower will set it up correctly.
    This is a first attempt at solving the issue of Flower booting up in a broken state.
    
    There can be a race condition from the moment we checked the condition to the moment we call flower.start() although unlikely.
    I will ponder on that...
    Tomasz-Kluczkowski committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    d5bc3c0 View commit details
    Browse the repository at this point in the history
  2. Update docker-compose.yml.

    As of celery 5 the command line invocation no longer supports specifying celery args after flower command.
    Also add depends_on for flower.
    Tomasz-Kluczkowski committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    8abfc0a View commit details
    Browse the repository at this point in the history
  3. Remove entry point.

    We no longer have `flower` as a separate command and this entrypoint was incorrect.
    We also need to be able to fully override the arguments for celery and flower via command line arguments when using the image.
    Tomasz-Kluczkowski committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    9c7beee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    71ed48c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    411309d View commit details
    Browse the repository at this point in the history
  6. Add changes to be mentioned if we get the release done.

    We should start adding those in this file as they are merged - I had hard time remembering what I have done over the last few months.
    Tomasz-Kluczkowski committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    a478338 View commit details
    Browse the repository at this point in the history
  7. Typo.

    Tomasz-Kluczkowski committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    621d23d View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Configuration menu
    Copy the full SHA
    0b2571c View commit details
    Browse the repository at this point in the history
  2. Fix tests.

    Tomasz-Kluczkowski committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    d380383 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Merge branch 'master' into investigate-no-comms-in-docker

    # Conflicts:
    #	CHANGES
    tomaszkluczkowski committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    3c4d047 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/investigate-no-comms-in-docker' …

    …into investigate-no-comms-in-docker
    tomaszkluczkowski committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    c73db38 View commit details
    Browse the repository at this point in the history