Support for complex object in ETag configuration (useful for MongoDB $oid)

[dokkis]

Similar support implemented for id tags, to support the MongoDB $oid also into the etag and not only in the id field by configuring the RestangularProvider as following:

RestangularProvider.setRestangularFields({
etag: '_etag.$oid'
});

Please integrate this pull request or resolve the problem in any other kind of way! :)

Thank you.

[daviesgeek]

Would you mind submitting some tests as well? I'll take a look at this, but it's always helpful to have tests with your PR.

[dokkis]

Hi, thank you for your fast answer. I added 4 tests:

testing ETag header
✔ Should GET an object with returning header ETag and set the ETag header value inside a simple etag attribute
✔ Should GET an object with returning header ETag and set the ETag header value inside a complex etag attribute
testing If-Match header to support ETag
✔ Should put the If-Match header with value retrieved by a simple etag attribute
✔ Should put the If-Match header with value retrieved by a complex etag attribute

testing ETag header tests that the ETag header is correctly retrieved by the response headers andits value is injected into the object (in the _etag attribute in the first test and _etag.$oid attribute in the second one). The first one was supported before, infact it's a regression test, the second test shows that with my improvements now Restangular can fill also complex object). The support is really similar to the 'id' field, I just made the things the same as for the id field.

testing If-Match header to support ETag tests that the If-Match header is populated correctly if it's declared inside the object. In the first test the etag is inside _etag attribute. For the second one is inside the _etag.$oid.

Hoping that this pull request will be integrated as soon as possible.

Thank you.

[daviesgeek]

Awesome thanks. I'll see what I can do about merging this.

[daviesgeek]

One more thing, sorry. Would you mind updating the docs to include the changes you made in this PR?

[dokkis]

Made it, I added into the FAQ after the "I use Mongo and the ID of the elements is _id not id as the default. Therefore requests are sent to undefined routes" because they are really close problems ;)

[daviesgeek]

Great thanks. Can you squash those three readme commits into one?

I'm waiting for the other contributors to review this before merging.

[dokkis]

Done the squash of the three last commits! Hope for good news about merging soon ;) In a project I had to invalidate etag support of restangular and introduce the etag support on my own and this PR will fix it!

[daviesgeek]

Awesome thanks. I need to test this a little more, then I'll merge it before the next release

[dokkis]

Good :) Take the required time to review and test my PR ;)

[dokkis]

any news on this PR?

[daviesgeek]

Sorry, life's been a bit crazy. I was trying to test this with a PHP server, but I was unable to ever get Restangular to save the Etag header to the element. Can you confirm that this is the case? Or am I completely misunderstanding the way this works?

[dokkis]

As you can see from the tests and test description it should assign the value of ETag header inside the object, my PR fix the fact that the etag object can be a complex object, example _etag.$oid. The implementation is the same made to support complex object on the id field.

"testing ETag header tests that the ETag header is correctly retrieved by the response headers andits value is injected into the object (in the _etag attribute in the first test and _etag.$oid attribute in the second one). The first one was supported before, infact it's a regression test, the second test shows that with my improvements now Restangular can fill also complex object). The support is really similar to the 'id' field, I just made the things the same as for the id field.