Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the fix for the webflow #757

Closed
wants to merge 8 commits into from

Conversation

DEVDESAGAR1
Copy link

@DEVDESAGAR1 DEVDESAGAR1 commented May 9, 2024

Adding the fix for the webflow

fixes #756

composer.json Outdated Show resolved Hide resolved
@mglaman
Copy link
Owner

mglaman commented May 10, 2024

Well, that sucks. \DrupalFinder\DrupalFinderComposerRuntime::getVendorDir is picking up InstalledVersions from within the PHPStan phar so it's broken with getVendorDir

@webflo
Copy link
Contributor

webflo commented May 10, 2024

Well, that sucks. \DrupalFinder\DrupalFinderComposerRuntime::getVendorDir is picking up InstalledVersions from within the PHPStan phar so it's broken with getVendorDir

Lets try to harden this part. Another approach I have tried some time ago was an composer plugin which dumps the config.

https://github.com/webflo/drupal-finder-plugin/blob/1.x/src/DrupalFinderPlugin/Installer.php#L163

@mglaman
Copy link
Owner

mglaman commented May 12, 2024

@webflo thanks for looking into this, I paused and did a pivot at DrupalCon

@weitzman
Copy link

Any chance we can fix this soon? Would help at ddev/ddev-drupal-contrib#53

@webflo
Copy link
Contributor

webflo commented Jun 18, 2024

@weitzman Could you try webflo/drupal-finder#73 thanks! This is my preferred approach. Thanks!

@weitzman
Copy link

weitzman commented Jun 19, 2024

Unfortunately I dont have time to test phpstan-drupal with the PR. And Drush no longer uses drupal-finder.

@webflo
Copy link
Contributor

webflo commented Jun 28, 2024

I have created a new release for drupal-finder

@mglaman
Copy link
Owner

mglaman commented Jun 28, 2024

Thanks @webflo!

@webflo
Copy link
Contributor

webflo commented Sep 24, 2024

Superseded by #790

@mglaman mglaman closed this in #790 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants