Remove added colon in comment-spacings rule
#981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfariasalves-ionos
changed the title
comment-spacings rulecomment-spacings rule
chavacava
reviewed
Apr 19, 2024
chavacava
reviewed
Apr 19, 2024
chavacava
reviewed
Apr 19, 2024
chavacava
reviewed
Apr 19, 2024
|
Thank you @gfariasalves-ionos for the PR. I've left some nit comments on the documentation of the rule. |
|
Please check again :) |
|
Merged. Thanks Gustavo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, describe in details what's your motivation for this PR:
Some projects like Kubebuilder have markers that do not follow the pattern //name:, e.g.: //+optional. Due to a colon added at the end of the values when parsing the arguments, revive complains about comments starting with the marker even if one adds it as an exception.
Did you add tests?
The current tests are still valid with the changes.
Does your code follow the coding style of the rest of the repository?
Yes.
Closes #980