Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds comments-density rule #979

Merged
merged 2 commits into from
Apr 20, 2024
Merged

adds comments-density rule #979

merged 2 commits into from
Apr 20, 2024

Conversation

chavacava
Copy link
Collaborator

This PR adds a new rule comments-density.
The rule is inspired on the SonarQube rule on the comment lines density metric

The default argument value of the rule is 0, i.e. the rule is de-facto deactivated, to avoid polluting analysis of those using enableAllRules = true in the configuration.

@denisvmedia
Copy link
Collaborator

I'd happily review it tomorrow evening (PRG time).

Thanks for the PR!

Copy link
Collaborator

@denisvmedia denisvmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with a minor nit)

@chavacava chavacava merged commit 9b29784 into master Apr 20, 2024
4 checks passed
@denisvmedia denisvmedia deleted the comments-density branch April 20, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants