Load config from different locations prefer XDG_CONFIG_HOME before HOME #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfederowicz
changed the title
mfederowicz
force-pushed
the
xdg-config-home
branch
from
409302b
to
51f4f39
Compare
|
@chavacava can you look at my changes? Sorry for go.sum mess but I can find solution to make file with latest checksums for packages :( |
…riables) - using afero for mocking fs
mfederowicz
force-pushed
the
xdg-config-home
branch
from
27be378
to
0eb4c9f
Compare
mfederowicz
force-pushed
the
xdg-config-home
branch
from
8403e1d
to
6f25fe5
Compare
chavacava
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Hi @mfederowicz, thank you for the PR!
I've left some comments and minor formatting suggestions.
Co-authored-by: chavacava <[email protected]>
Co-authored-by: chavacava <[email protected]>
|
ok @chavacava I commited changes with yours suggestions, let me know i all good, and then we can squash commits and go to master :P |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base on #725
make some cleanup, and tests using github.com/spf13/afero package for mocking filesystem