check clear/max/min in redefines-builtin-id rule on go1.21+ #1024
Conversation
| @@ -32,3 +32,12 @@ var i, copy int // MATCH /redefinition of the built-in function copy/ | |||
|
|
|||
| // issue #792 | |||
| type () | |||
|
|
|||
| func foo() { | |||
| clear := 0 // MATCH /redefinition of the built-in function clear/ | |||
There was a problem hiding this comment.
revive itself requires go1.21. So I don't add any condition for go version here.
https://github.com/mgechev/revive/blob/master/go.mod#L3
I manually confirmed that the following code does not report any errors:
go.mod:
module playground
go 1.20main.go
// package comment
package main
func main() {
clear := 0
_ = clear
}❯ revive -set_exit_status
❯ echo $?
0
Co-authored-by: Denis Voytyuk <[email protected]>
| @@ -33,6 +33,7 @@ var ( | |||
| falseValue = 2 | |||
| notSet = 3 | |||
|
|
|||
| go121 = goversion.Must(goversion.NewVersion("1.21")) | |||
There was a problem hiding this comment.
I'm wondering: isn't go 1.21 already EOL? Because if it is, we should better use the existing go122 constant.
There was a problem hiding this comment.
isn't go 1.21 already EOL?
Yes, go 1.21 is EOL.
Because if it is, we should better use the existing go122 constant.
Does this mean "revive does not care about EOL go"?
Then, I think we should just add clear/max/min to builtFunctions unconditionaly.
However, I'm not unwilling to use go122 / IsAtLeastGo122 here.
There was a problem hiding this comment.
Then, I think we should just add clear/max/min to builtFunctions unconditionaly.
👍
Suggesting to avoid using function named max/min is not really a problem, even for version under go 1.21. They could be renamed even if max/min is not available
There was a problem hiding this comment.
revive itself requires Go 1.21 and it will eventually require 1.22 because 1.21 is EOL but it should be possible to use revive to analyze Go code bases of any version.
|
@denisvmedia @ccoVeille @chavacava |
Close #1021
go1.21 has introduced new functions
clear,maxandmin.It would be nice revive checks these functions in redefines-builtin-id rule on go1.21+.