Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated with peer #116

Open
wants to merge 2 commits into
base: major_refactor
Choose a base branch
from
Open

updated with peer #116

wants to merge 2 commits into from

Conversation

raghavdhingra
Copy link
Member

No description provided.

@raghavdhingra raghavdhingra added the enhancement New feature or request label Jul 11, 2021
@raghavdhingra raghavdhingra self-assigned this Jul 11, 2021
@netlify
Copy link

netlify bot commented Jul 11, 2021

❌ Deploy Preview for inc0g failed.

🔨 Explore the source changes: 1e75dfa

🔍 Inspect the deploy log: https://app.netlify.com/sites/inc0g/deploys/60eadff09227fc0007a8ae04

@@ -198,14 +178,54 @@ const Video = () => {
// eslint-disable-next-line
}, [isAskForUsername, isVideoActive, isAudioActive]);

function addVideoStream(video, stream) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this to fat arrow or convert others to function syntax

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 11, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e75dfa
Status: ✅  Deploy successful!
Preview URL: https://8e69d8d0.incogly.pages.dev

View logs

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

Please see inline comments.

@@ -19,7 +18,7 @@ const Home = () => {
return (
<div className="home_page__container">
<NavBar />
<Container>
<div className="container">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this bem compliant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants