fix(api): add stats to inbound lambda #2068

Orta21 · 2024-05-10T18:45:59Z

Ref. metriport/metriport-internal#1669

Ticket: #1889

Dependencies

Upstream: https://github.com/metriport/metriport-internal/pull/1809
Downstream: none

Description

Add analytics to inbound to determine how often we respond with docs after Patient Match

Testing

Staging
- Infra works accordingly
- Able to see analytics for inbound requests
Production
- Infra works accordingly
- Able to see analytics for inbound requests

Release Plan

Upstream PR is merged
Release NPM packages
Merge this

Ref. metriport/metriport-internal#1669

Orta21 · 2024-05-10T18:47:02Z

packages/api/src/command/medical/document/document-conversion-status.ts

@@ -70,7 +70,7 @@ export async function calculateDocumentConversionStatus({
 });

 if (isConversionCompleted) {
- const startedAt = updatedPatient.data.documentQueryProgress?.startedAt;
+ const startedAt = externalData?.documentQueryProgress?.startedAt;


Forgot about this but its affected by scheduling the DQ so need to get the HIE startAt

Orta21 · 2024-05-10T18:48:56Z

packages/ihe-gateway-sdk/src/models/document-query/document-query-responses.ts

@@ -17,7 +17,9 @@ export type InboundDocumentQueryRespSuccessful = z.infer<
 typeof inboundDocumentQueryRespSuccessfulSchema
 >;

-const inboundDocumentQueryRespFaultSchema = baseErrorResponseSchema;
+const inboundDocumentQueryRespFaultSchema = baseErrorResponseSchema.extend({
+ extrinsicObjectXmls: z.never().or(z.literal(undefined)),


If i dont set as never when erroringi cant extract from result when successful

Orta21 · 2024-05-10T18:49:21Z

packages/ihe-gateway-sdk/src/models/document-retrieval/document-retrieval-responses.ts

-const inboundDocumentRetrievalRespFaultSchema = baseErrorResponseSchema;
+const inboundDocumentRetrievalRespFaultSchema = baseErrorResponseSchema.extend({
+ documentReference: z.never().or(z.literal(undefined)),
+});


Ref. metriport/metriport-internal#1669

Ref: #000 - [email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected]

Ref. metriport/metriport-internal#1669

Ref: #000 - [email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected]

Orta21 · 2024-05-10T19:03:23Z

packages/api/src/shared/config.ts

- static getPostHogApiKey(): string | undefined {
- return getEnvVar("POST_HOG_API_KEY");
- }
-


Moved to core

I see it was moved to core, but we need to add code to the lambda to get the value from the env var and call the AWS SDK to get the value of the secret w/ the env var content.

RamilGaripov

Left a comment, which is kind of a nit... Address at your discretion 😄

Also, would be good to release NPM packages after a PR is approved, so:

there are no iterations on NPM releases in case a change is requested in a published package, and
the pkg version updates don't litter the PR

packages/infra/lib/ihe-stack.ts

leite08 · 2024-05-14T00:32:37Z

packages/api/src/shared/config.ts

- static getPostHogApiKey(): string | undefined {
- return getEnvVar("POST_HOG_API_KEY");
- }
-


I see it was moved to core, but we need to add code to the lambda to get the value from the env var and call the AWS SDK to get the value of the secret w/ the env var content.

packages/infra/lib/ihe-stack.ts

Ref. metriport/metriport-internal#1669

Ref: #000 - [email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected]

Ref. metriport/metriport-internal#1669

leite08 · 2024-05-22T16:33:23Z

packages/lambdas/src/ihe-inbound-document-query.ts

+ if (postHogSecretName) {
+ postHogApiKey = await getSecretValue(postHogSecretName, region);
+ }


Does it make sense to call analytics if there's no API key?

leite08 · 2024-05-22T16:41:35Z

packages/core/src/util/config.ts

+ static getUseMockS3Utils(): boolean {
+ return getEnvVar("USE_MOCK_S3_UTILS") === "true";
+ }


This is not part of this PR, is it?

Ill remove since its not being used anywere but seems like its already part of the code

Sounds good!

seems like its already part of the code

FYI, that usually happens after a bad conflict resolution.

leite08 · 2024-05-22T16:44:00Z

packages/core/src/external/analytics/posthog.ts

- const posthog = new PostHog(postApiKey);
+export const analytics = (params: EventMessageV1, postApiKey?: string) => {
+ const apiKey = postApiKey ?? defaultPostHogApiKey;
+ if (apiKey) {


nit: since we're touching this, could make this return if no api key available, instead of having the main flow inside an if

NABD, though

Ref. metriport/metriport-internal#1669

Ref. metriport/metriport-internal#1669 Signed-off-by: Jorge Orta <[email protected]>

fix(api): add stats to inbound lambda

7f094a1

Ref. metriport/metriport-internal#1669

Orta21 commented May 10, 2024

View reviewed changes

Orta21 added 4 commits May 10, 2024 14:50

fix(api): fix api key

00db1c7

Ref. metriport/metriport-internal#1669

fix(api): merge conflicts

30c9f56

Ref. metriport/metriport-internal#1669

Orta21 commented May 10, 2024

View reviewed changes

Orta21 marked this pull request as ready for review May 10, 2024 19:04

Orta21 requested review from Goncharo, leite08, RamilGaripov and jonahkaye as code owners May 10, 2024 19:04

RamilGaripov approved these changes May 13, 2024

View reviewed changes

packages/infra/lib/ihe-stack.ts Show resolved Hide resolved

leite08 requested changes May 14, 2024

View reviewed changes

Orta21 added 4 commits May 22, 2024 09:03

feat(api): handle merge conflicts

999c39a

Ref. metriport/metriport-internal#1669

feat(api): checkpoint

cc277b4

Ref. metriport/metriport-internal#1669

feat(api): ihe inbound get secret

98bd752

Ref. metriport/metriport-internal#1669

leite08 reviewed May 22, 2024

View reviewed changes

feat(api): dont call analytics if no key

03287a9

Ref. metriport/metriport-internal#1669

leite08 approved these changes May 22, 2024

View reviewed changes

Orta21 added 3 commits May 23, 2024 09:11

feat(api): handle merge conflicts

82ef35e

Ref. metriport/metriport-internal#1669

feat(api): nit

6d72d4c

Ref. metriport/metriport-internal#1669

feat(api): sign off

3a220e6

Ref. metriport/metriport-internal#1669 Signed-off-by: Jorge Orta <[email protected]>

Orta21 added this pull request to the merge queue May 23, 2024

Merged via the queue into develop with commit 87cb73a May 23, 2024
35 checks passed

Orta21 deleted the 1669-inbound-stats branch May 23, 2024 13:22

Orta21 mentioned this pull request May 23, 2024

RELEASE 1669 #2146

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(api): add stats to inbound lambda #2068

fix(api): add stats to inbound lambda #2068

Orta21 commented May 10, 2024 •

edited

Orta21 May 10, 2024

Orta21 May 10, 2024 •

edited

Orta21 May 10, 2024

Orta21 May 10, 2024

leite08 May 14, 2024

RamilGaripov left a comment

leite08 May 14, 2024

leite08 May 22, 2024

leite08 May 22, 2024

Orta21 May 22, 2024

leite08 May 22, 2024

leite08 May 22, 2024

fix(api): add stats to inbound lambda #2068

fix(api): add stats to inbound lambda #2068

Conversation

Orta21 commented May 10, 2024 • edited

Dependencies

Description

Testing

Release Plan

Choose a reason for hiding this comment

Orta21 May 10, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RamilGaripov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Orta21 commented May 10, 2024 •

edited

Orta21 May 10, 2024 •

edited