Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ihe-gateway): fixed null pointer issue for xcpd #1898

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RamilGaripov
Copy link
Contributor

refs. metriport/metriport-internal#1350

Description

  • Fixing null pointer exception for XCPD in ihe gateway

Testing

  • Production
    • Make sure new XCPDs are coming thru

Release Plan

  • ⚠️ Points to master
  • Merge this

Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also identified there are other places using hasOwnProperty() to check for the presence of a property.

Can we create a ticket to address those as part of the release plan of this PR, please?

Approving considering that ^, I can help w/ the ticket if you're swamped. 👍

@RamilGaripov RamilGaripov marked this pull request as draft April 15, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants