Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.16 #13066

Merged
merged 140 commits into from May 14, 2024
Merged

Release 2.16 #13066

merged 140 commits into from May 14, 2024

Conversation

nachocodoner
Copy link
Member

@nachocodoner nachocodoner commented Mar 21, 2024

meteor update --release 2.16
# or 
meteor create appname --release  2.16

We'll make sure Meteor 3.x isn't affected by new additions in this release. Tracking progress on PR #13098.

Best Candidates

These are the top PR candidates for the next release, focusing on Meteor 3.x migration. Original authors will address any necessary checks, with the core team reviewing for compatibility with both 2.x and future 3.x versions.

Quick Gains

These PRs are straightforward and expected to integrate smoothly into Meteor 3.x, offering immediate benefits. We will double check them on a release-3.0 based-branch.

Hotfixes

Update terser to v5.31.0
#13120

Discarded

Other PRs are currently excluded from the upcoming release due to the effort needed for verification and potential impact on Meteor 3.x transition, which remains our primary focus.

DDP resumption
#12436

Update Accounts with Async methods
#12647

Remove underscore
#12245
#12261
#12259
#12238
#12267

Asyncify _checkForCaseInsensitiveDuplicates
#13076


Any other PR to be considered for including in 2.16 release must point release-2.16 branch, update to latest changes, have green checks on that branch, and ask for a review keeping the PR alive.

harryadel and others added 30 commits October 21, 2022 13:43
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Updated the exclude so that it doesn't exclude `"!./.meteor/local/types"`. Prior to this, intellisense for my package's types wasn't working.

From `zodern:types`:
If your tsconfig has exclude configured, make sure the exclude rules do not exclude `.meteor/local/types`
No Node 12 tests, which should slightly speed things up.
- update npm-shrinkwrap.json from email package
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 19:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 19:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 28, 2024 08:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 28, 2024 08:37 Inactive
@StorytellerCZ
Copy link
Collaborator

StorytellerCZ commented Apr 28, 2024

Got an interesting error when trying to update:

While selecting package versions:
error: No version of logging satisfies all constraints: @1.3.4-beta2160.1, @=1.3.3, @~1.3.4-beta2160.1
Constraints on package "logging":
* [email protected] <- top level
* logging@=1.3.3 <- top level
* logging@~1.3.4-beta2160.1 <- top level
* [email protected] <- webapp 1.13.8 <- accounts-oauth 1.4.4-beta2160.1 <- accounts-facebook 1.3.3
* [email protected] <- webapp 1.13.8 <- communitypackages:fast-render 3.3.1
* [email protected] <- mongo 1.16.10-beta2160.1
* [email protected] <- percolate:migrations 1.0.3
* [email protected] || 1.3.1 || 1.3.3-beta300.6 <- reywood:publish-composite 1.8.8
* [email protected] <- email 2.2.6-beta2160.1
* [email protected] <- oauth 2.2.1 <- accounts-oauth 1.4.4-beta2160.1 <- accounts-facebook 1.3.3
* [email protected] <- oauth 2.2.1 <- bozhao:link-accounts 2.8.0
* [email protected] <- storyteller:fictionaltime 0.4.1

Given that this is a patch update, I wonder if this one is the issue:

[email protected] || 1.3.1 || 1.3.3-beta300.6 <- reywood:publish-composite 1.8.8

This looks like an issue with the 3.0 release having an overlap with an existing package release.

Update: After updating to reywood:publish-composite and storyteller:fictionaltime to have the latest 3.0-rc.0 in their versionsFrom resolution they disappeared from the list, so I think that need to be fixed in other packages if the app wants to update for the beta. I think this won't be a problem after the full release.

Update 2: So in the end it seems to be something at the top level that is forcing the 1.3.3 version of the logging package. Even if I remove the package from my packages list it, this line still remains: * logging@=1.3.3 <- top level

@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 14:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 14:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 15:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 15:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 6, 2024 13:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 6, 2024 13:54 Inactive
@StorytellerCZ
Copy link
Collaborator

I think we can move to RC here.

@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 14:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 14:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 15:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 15:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 17:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 17:20 Inactive
@denihs denihs merged commit 860729b into devel May 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment