Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable TypeScript self-test #12934

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
+29 −29
Open

Re-enable TypeScript self-test #12934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/logging/logging.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
type LogJSONInput = {
message: string;
app?: string;
[index: string]: string | object | number;
[index: string]: string | object | number | undefined;
};

type LogInput = string | LogJSONInput;
Expand Down
2 changes: 1 addition & 1 deletion packages/meteor/meteor.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export namespace Meteor {
>(
name: string,
args: ReadonlyArray<EJSONable | EJSONableProperty>,
options?: MethodApplyOptions,
options?: MethodApplyOptions<Result>,
asyncCallback?: (
error: global_Error | Meteor.Error | undefined,
result?: Result
Expand Down
54 changes: 27 additions & 27 deletions tools/tests/typescript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
// var selftest = require('../tool-testing/selftest.js');
// var Sandbox = selftest.Sandbox;
//
// selftest.define("typescript template works", function () {
// const s = new Sandbox;
//
// let run = s.run("create", "--typescript", "typescript");
//
// run.waitSecs(60);
// run.match("Created a new Meteor app in 'typescript'.");
// run.match("To run your new app");
//
// s.cd("typescript");
//
// run = s.run("npm", "install");
// run.expectExit(0);
//
// run = s.run("lint");
// run.waitSecs(60);
// run.match("[zodern:types] Exiting \"meteor lint\" early");
// run.expectExit(0);
//
// run = s.run("npx", "tsc");
// run.waitSecs(60);
// run.expectEnd();
// run.expectExit(0);
// });
var selftest = require('../tool-testing/selftest.js');
var Sandbox = selftest.Sandbox;

selftest.define("typescript template works", function () {
const s = new Sandbox;

let run = s.run("create", "--typescript", "typescript");

run.waitSecs(60);
run.match("Created a new Meteor app in 'typescript'.");
run.match("To run your new app");

s.cd("typescript");

run = s.run("npm", "install");
run.expectExit(0);

run = s.run("lint");
run.waitSecs(60);
run.match("[zodern:types] Exiting \"meteor lint\" early");
run.expectExit(0);

run = s.run("npx", "tsc");
run.waitSecs(60);
run.expectEnd();
run.expectExit(0);
});