test: add .cjs test script & fix test issues

.eslintignore

@@ -1 +1,2 @@
-lib
+lib
+test/index.cjs

.gitignore

@@ -5,6 +5,7 @@ npm-debug.log*
 coverage
 coverage.info
 test/fixtures/*/build
+test/index.cjs
 node_modules
 lib/*.map
 lib/*.cjs

lib/index.d.ts

@@ -1,5 +1,5 @@
 import { Plugin } from 'metalsmith';
-export default initializeInPlace;
+export default inPlace;
 export type Render = (source: string, options: any, locals: any) => string;
 export type RenderAsync = (source: string, options: any, locals: any, callback: Function) => Promise<string>;
 export type Compile = (source: string, options: any) => string;
@@ -54,4 +54,4 @@ export type Options = {
  *     }
  *   }}))
  */
-declare function initializeInPlace(options?: Options): Plugin;
+declare function inPlace(options?: Options): Plugin;

package.json

@@ -32,6 +32,7 @@
     "format": "prettier --write \"**/*.{yml,md,js,json}\"",
     "format:check": "prettier --list-different \"**/*.{yml,md,js,json}\"",
     "test": "c8 mocha",
+    "test:cjs": "microbundle -i test/index.js -o test/index.cjs -f cjs --target=node --pkg-main=false --no-sourcemap --external assert-dir-equal,metalsmith,jstransformer-pug --generateTypes=false && mocha test/index.cjs",
     "release": "release-it",
     "build": "microbundle --target node -f cjs,esm --strict --generateTypes=false",
     "prepack": "npm run build",

src/index.js

@@ -175,11 +175,12 @@ function inPlace(options = {}) {
     // Let the user know when there are no files to process
     if (validFiles.length === 0) {
       debug.warn('No valid files to process.')
-      return done()
-    } else {
-      debug('Rendering %s files', validFiles.length)
+      done()
+      return
     }
 
+    debug('Rendering %s files', validFiles.length)
+
     // Map all files that should be processed to an array of promises and call done when finished
     return Promise.all(validFiles.map((filename) => render({ filename, files, metalsmith, options, transform })))
       .then(() => done())

test/index.js

@@ -100,8 +100,8 @@ describe('@metalsmith/in-place', () => {
     })
   })
 
-  it('should throw on unresolved transform option', (done) => {
-    Promise.allSettled([
+  it('should throw on unresolved transform option', () => {
+    return Promise.allSettled([
       Metalsmith(fixture('transform-option'))
         .env('DEBUG', process.env.DEBUG)
         .use(plugin({ transform: 'invalid' }))
@@ -115,17 +115,15 @@ describe('@metalsmith/in-place', () => {
         .use(plugin({ transform: 'jstransformer-invalid' }))
         .process()
     ]).then((promises) => {
-      for (let i = 0; i < 3; i++) {
-        const reason = promises[i].reason
-        try {
-          strictEqual(reason instanceof Error, true)
-          strictEqual(reason.code, 'ERR_MODULE_NOT_FOUND')
-        } catch (err) {
-          done(err)
-          break
-        }
-      }
-      done()
+      deepStrictEqual(
+        promises.map((p) => p.status),
+        ['rejected', 'rejected', 'rejected']
+      )
+      // in ESM, this yields ERR_MODULE_NOT_FOUND, but in CJS the ERR_ prefix is omitted
+      deepStrictEqual(
+        promises.map((p) => p.reason.code.replace('ERR_', '')),
+        ['MODULE_NOT_FOUND', 'MODULE_NOT_FOUND', 'MODULE_NOT_FOUND']
+      )
     })
   })