Adding the ability to configure event listener options, restoring ability to prevent preventDefault() in pointerDown #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2019 13:25
… function hook for skipping preventingDefault in pointerDown
…s removed in 2.3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from PR to Unipointer: metafizzy/unipointer#8
Same reasoning around the need for adding
listenerOptsapplies.I'm also hoping you reconsider leaving the ability to prevent
event.preventDefault()in pointerDown, without actually quitting the event chain viathis.okayPointerDown(). The main reason for allowing the event chain to continue withoutevent.preventDefault()is to allow inner elements with'click'handlers a chance to fire. Prevent default intouchstartstops the chain and prevents these events from firing. The structure I've outlined would make this behavior opt-in, leaving the always preventing behavior the default.Also included a minor fix in the README, which was referencing an internal property that was removed.