Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1395: Fix JSPF track identifier to be a list of strings #115

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phw
Copy link
Member

@phw phw commented Nov 14, 2023

According to the XSPF/JSPF spec [1] a track can have an arbitrary number of identifiers. For JSPF this means the "identifier" field must be a list [2].

[1] https://xspf.org/spec#4112141112-identifier
[2] https://xspf.org/jspf

TODO:

According to the XSPF/JSPF spec [1] a track can have an arbitrary number
of identifiers. For JSPF this means the "identifier" field must be
a list [2].

[1] https://xspf.org/spec#4112141112-identifier
[2] https://xspf.org/jspf
@phw
Copy link
Member Author

phw commented Nov 14, 2023

@mayhem @amCap1712 before I proceed here, can you verify that this format change is the proper thing to do?

@mayhem
Copy link
Member

mayhem commented Nov 14, 2023

Indeed, well spotted. However we need to take care when releasing this PR -- we need to update listenbrainz-server as well, otherwise we'll get import failures if one if releases before the other.

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before we merge this we need to do the LB side of things as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants