Ensure config tests remove the config file after deleting the object

metabrainz · Apr 30, 2024 · 064d879 · 064d879
1 parent df7036a
commit 064d879
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/test/test_config.py b/test/test_config.py
@@ -47,7 +47,6 @@ def setUp(self):
 
  self.configpath = os.path.join(self.tmp_directory, 'test.ini')
  shutil.copy(os.path.join('test', 'data', 'test.ini'), self.configpath)
- self.addCleanup(os.remove, self.configpath)
 
  self.config = Config.from_file(None, self.configpath)
  self.addCleanup(self.cleanup_config_obj)
@@ -61,6 +60,7 @@ def cleanup_config_obj(self):
  self.config.sync()
  del self.config
  self.config = None
+ os.remove(self.configpath)
 
 
 class TestPicardConfig(TestPicardConfigCommon):

diff --git a/test/test_profiles.py b/test/test_profiles.py
@@ -58,7 +58,6 @@ def setUp(self):
 
  self.configpath = os.path.join(self.tmp_directory, 'test.ini')
  shutil.copy(os.path.join('test', 'data', 'test.ini'), self.configpath)
- self.addCleanup(os.remove, self.configpath)
 
  self.config = Config.from_file(None, self.configpath)
  self.addCleanup(self.cleanup_config_obj)
@@ -94,6 +93,7 @@ def cleanup_config_obj(self):
  self.config.sync()
  del self.config
  self.config = None
+ os.remove(self.configpath)
 
  def get_profiles(self, enabled=True):
  profiles = []