Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaygain2: support writing both standard and R128 tags to Opus files #381

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

phw
Copy link
Member

@phw phw commented Sep 8, 2024

Currently the replaygain2 plugin supports writing either the standard ReplayGain tags or the R128 tags for Opus files, but not both.

I discovered that Navidrome only handles the standard tags, but I also need the the R128 tags for another tool. Having both gives compatibility with both.

See also complexlogic/rsgain#119 , but the plugin can do this independently has it is Picard writing the final tags anyway.

@phw phw requested a review from zas September 8, 2024 11:38
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 0ec78c2 into metabrainz:2.0 Sep 8, 2024
7 checks passed
@phw phw deleted the replaygain_opus_mode_both branch September 8, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants