Migrate React /component components to Flow component syntax #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
flow-component-syntax-components
branch
2 times, most recently
from
8f44e84
to
76eee9d
Compare
reosarevok
force-pushed
the
flow-component-syntax-components
branch
from
76eee9d
to
6448c39
Compare
mwiencek
reviewed
May 17, 2024
mwiencek
approved these changes
May 17, 2024
reosarevok
force-pushed
the
flow-component-syntax-components
branch
from
6448c39
to
ed3a639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow now supports a specific React Component Syntax which reduces the amount of types we need to define manually, and is supposed to be better for type checking as well. I'm converting our React components to this syntax bit by bit with this PR.
This changes all stuff in the
componentssubfolder.Note: To be reviewed without whitespace changes (since this adds explicit
return()calls that require spacing things one more tab in many cases).On top of #3230