New OAuth login page #391
Open
New OAuth login page #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Initial commit with basic HTML + CSS
This comment has been minimized.
This comment has been minimized.
so that we can use the same styles for the signup (create account) page
+ made some links real
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Initial commit with basic HTML + CSS
so that we can use the same styles for the signup (create account) page
+ made some links real
Unit Test Results 1 files 1 suites 22s ⏱️ Results for commit 34af6be. |
reosarevok
reviewed
May 19, 2023
|
|
||
| <div class="auth-card"> | ||
| <h1 class="page-title text-center">{{ _('Create your account') }}</h1> | ||
| <div class="h4 text-center">access all MetaBrainz projects</div> |
There was a problem hiding this comment.
Suggested change
| <div class="h4 text-center">access all MetaBrainz projects</div> | |
| <div class="h4 text-center">to access all MetaBrainz projects</div> |
?
reosarevok
reviewed
May 19, 2023
Comment on lines
+102
to
+110
| <p>Note that any contributions you make to MusicBrainz will be released into the Public Domain and/or licensed under a Creative Commons by-nc-sa license. | ||
| Furthermore, you give the MetaBrainz Foundation the right to license this data for commercial use. | ||
| <br/>Please read our <a>license page</a> for more details. | ||
| <p>MusicBrainz believes strongly in the privacy of its users. Any personal information you choose to provide will not be sold or shared with anyone else. | ||
| <br/>Please read our <a>privacy policy</a> for more details.</p> | ||
| <p>You may remove your personal information from our services anytime by deleting your account. | ||
| <br/>Please read our <a>GDPR compliance statement</a> for more details.</p> | ||
| <p>Creating an account on MetaBrainz will give you access to accounts on our other services, such as ListenBrainz, MusicBrainz, BookBrainz, and more. | ||
| <br/>We do not automatically create accounts for these services when you create a MetaBrainz account, but you will only be a few clicks away doing so.</p> |
There was a problem hiding this comment.
Is this text meant to be the actual one? It seems weird to have so much MB-specific data (what is the licensing for BB for example?) when we later say we won't anyway automatically create an MB account. We should probably have either a tiny bit on the licenses for each project, or just say we don't auto-create the sub-accounts and you can see each project's licensing stuff when creating those.
reosarevok
reviewed
May 19, 2023
Comment on lines
+111
to
+113
| <button class="btn btn-primary center-block" type="button" data-dismiss="modal"> | ||
| Sounds good | ||
| </button> |
There was a problem hiding this comment.
Why have a separate button for this? If we do, shouldn't we have a second button for "I don't like this, get me out of here"? :D But honestly just "hide" seems better to me than "sounds good", in theory.
…ainz.org into new-login-page
amCap1712
force-pushed
the
new-oauth
branch
2 times, most recently
from
c261c1e
to
14082c4
Compare
amCap1712
force-pushed
the
new-oauth
branch
from
14082c4
to
d7f0a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the presentational aspect so far, functionally it's going to be missing all the guts.