Port metric v1 e2e tests #42125
Merged
Port metric v1 e2e tests #42125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
metamben
commented
May 2, 2024
| @@ -845,6 +845,79 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => { | |||
| .contains("[Revenue]"); | |||
| }); | |||
| }); | |||
|
|
|||
| it("should be possible to sort by metric (metabase#8283)", () => { | |||
There was a problem hiding this comment.
Scavenged from the admin metrics tests.
metamben
commented
May 2, 2024
| cy.findByText("Created At is Jan 1–31, 2024").should("be.visible"); | ||
| }); | ||
| // FIXME metrics v2 -- check that the values in column Total are above 150 |
There was a problem hiding this comment.
I'm not sure how to do this best. Ideally, we would like to check that the filter is still in effect, but I don't think it should be listed as it's part of the metric which is still the source.
metamben
commented
May 2, 2024
| // FIXME metrics v2 | ||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| it.skip("should return fields from the model question's virtual card table, as though it is already nested", () => { | ||
| it("should return fields from the model question's virtual card table, as though it is already nested", () => { |
There was a problem hiding this comment.
I can't see how this is related to metrics, so I think it should pass.
metamben
commented
May 2, 2024
| // FIXME metrics v2 | ||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| it.skip("does not show custom warning modal when saving new model", async () => { | ||
| it("does not show custom warning modal when saving new model", async () => { |
There was a problem hiding this comment.
I can't see how this is related to metrics, so I think it should pass.
ranquild
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.