Linkify rows in Browse models table #42111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
rafpaf
added
the
no-backport
Graphite App
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d2e2ae4...27244ea.
|
rafpaf
force-pushed
the
browse/linkify-row
branch
2 times, most recently
from
17408e3
to
29ffce1
Compare
rafpaf
force-pushed
the
browse/linkify-row
branch
2 times, most recently
from
8e10382
to
e55a55b
Compare
iethree
requested changes
May 8, 2024
frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.styled.tsx
Outdated
Show resolved
Hide resolved
rafpaf
force-pushed
the
browse/linkify-row
branch
2 times, most recently
from
ad7f9c7
to
5a14d91
Compare
iethree
approved these changes
May 9, 2024
rafpaf
force-pushed
the
browse/linkify-row
branch
from
f6c21de
to
1d56f81
Compare
|
@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR makes the rows of the ModelsTable component clickable, routing to the respective item's url.
What changed?
Created a new styled component,
ModelTableRow, to encapsulate the styling code for table rows inModelsTable. Now, when a user clicks on a row in the table, they are redirected to the URL of the item that row represents. It also prevents click propagation when the collection is clicked.How to test?
Visual testing can be performed by checking if clicking on table rows redirects to correct URL and whether the styling behaves as expected.
Why make this change?
This change enhances the user experience by allowing easier navigation.
(Graphite's AI wrote this PR description btw)