Cleanup parameters popover #42107
Merged
Cleanup parameters popover #42107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heypoom
approved these changes
May 2, 2024
uladzimirdev
commented
May 2, 2024
| @@ -89,28 +78,3 @@ export const ParameterOptionsSectionsPane = ({ sections, onSelectSection }) => ( | |||
| </ul> | |||
| </PopoverBody> | |||
| ); | |||
|
|
|||
| export const ParameterOptionItem = ({ option, onClick }) => ( | |||
| <OptionItemRoot onClick={onClick}> | |||
uladzimirdev
commented
May 2, 2024
| name={getParameterIconName(section.id)} | ||
| className={CS.mr1} | ||
| /> | ||
| <Icon size="16" name="label" className={CS.mr1} /> |
There was a problem hiding this comment.
typescript showed that getParameterIconName expected parameter object and not id, so it never worked as intended and nobody noticed. I just hardcoded the fallback value from getParameterIconName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42163
Drop not used components and rework file to TS.
no-backportas it depends on other changes which weren't backported