Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple values for string operators in the query builder #42101

Merged
merged 12 commits into from May 8, 2024

Conversation

nemanjaglumac
Copy link
Member

@nemanjaglumac nemanjaglumac commented May 1, 2024

This PR is a part of the milestone 1 of #41956.

It expands the multi-select filter capabilities in the query builder to the "contains", "does not contain", "starts with" and "ends with" operators. This behavior was previously possible only for "is" and "is not" operators.

The scope of this PR is bringing the behavior up to par with the previous operators, as per the definition of the Milestone 1.

@nemanjaglumac nemanjaglumac changed the title Multiple values for string operators Multiple values for string operators [WIP] May 1, 2024
@nemanjaglumac nemanjaglumac marked this pull request as ready for review May 7, 2024 12:09
Copy link

github-actions bot commented May 7, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff e2c219b...7296d96.

Notify File(s)
@kdoh frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.tsx

Copy link

replay-io bot commented May 7, 2024

Status Complete ↗︎
Commit 7296d96
Results
⚠️ 8 Flaky
2471 Passed

@nemanjaglumac nemanjaglumac added the no-backport Do not backport this PR to any branch label May 7, 2024
@nemanjaglumac nemanjaglumac changed the title Multiple values for string operators [WIP] Allow multiple values for string operators in the query builder May 7, 2024
@nemanjaglumac nemanjaglumac requested review from mngr, AlessioLaiso and a team May 7, 2024 14:23
@nemanjaglumac nemanjaglumac merged commit f649367 into master May 8, 2024
114 checks passed
@nemanjaglumac nemanjaglumac deleted the multi-text-filters-notebook branch May 8, 2024 07:07
Copy link

github-actions bot commented May 8, 2024

@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants