4.x #124
4.x #124
Conversation
…nt work anymore and fix one test at the time
| <!-- Conditionally obtain references for the .NET Framework 4.0 target --> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net40' "> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="JWT" Version="8.2.3" /> |
There was a problem hiding this comment.
Really like the switch to target .net6.0.
Be ware that targetting .net6.0 might leave customers running on .NET Framework behind, as you are no longer targetting .netstandard 6.0.
https://docs.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-1-0#net-standard-not-deprecated
Is it possible to remove this dependency to JWT and switch over to System.Text.Json? That would result in a library with only framework dependencies.
JWT package still depends on Newtonsoft.Json, there is an issue on their side to replace it: jwt-dotnet/jwt#364
There was a problem hiding this comment.
Yes. I think it's time we leave the .NET Framework behind.
Well make a major change release and then people have a chance to stay on old versions.
About your idea of using System's Jason.. it looks like a very good one.
We have limited c# knowledge these days over here so if you can do a PR or point us on the right direction it would be amazing
|
hello @marcelcorso Is it wise to create an endpoint for JWT validation, which we can post the incoming JWT signature and our access key, and get a true/false result, like if true "yes this request came from us" and no"this request does not come from us" ? If it is logical, this means JWT library dependency can be dropped. |
|
@ahmetkocadogan doing another request to validate the JWT may be too slow. |
No description provided.