[release-2.2] ci: use vsphere base templates from d2iq-base-templates vsphere folder #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
changed the title
#870) * ci: use base d2iq templates * ci: set vsphere base templates from d2iq-base-templates directory
dkoshkin
force-pushed
the
dkoshkin/use-d2iq-base-templates-2.2
branch
from
893f901
to
50addfe
Compare
supershal
approved these changes
Sep 5, 2023
|
Fixed in #901, these changes were not enough anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
uses d2iq base templates to build KIB OVA.
When we disable the ssh_agent based authentication, the packer code uses temporary keypair generated during provisioning.
Existing logic that manages this is at: https://github.com/mesosphere/konvoy-image-builder/blob/main/pkg/packer/manifests/vsphere/packer.pkr.hcl#L378-L405