Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use Flatcar LTS version in e2e tests #826

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Jun 6, 2023

What problem does this PR solve?:
In DKP 2.5 DKP switched to supporting the Flatcar LTS version, switching the TF lookup vars to find the latest LTS version.

Removed source_ami as ami_filter_name takes precedence.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@dkoshkin dkoshkin requested a review from a team June 6, 2023 16:21
@dkoshkin dkoshkin self-assigned this Jun 6, 2023
@dkoshkin dkoshkin added runs-e2e-tests runs e2e tests for GHA runs-aws-tests and removed runs-e2e-tests runs e2e tests for GHA labels Jun 6, 2023
Copy link
Collaborator

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. this is a lot better

images/ami/flatcar.yaml Outdated Show resolved Hide resolved
@dkoshkin
Copy link
Contributor Author

dkoshkin commented Jun 6, 2023

Linter errors are unrelated and were fixed in #827

@dkoshkin dkoshkin merged commit cea5d51 into main Jun 6, 2023
@dkoshkin dkoshkin deleted the dkoshkin/ci-flatcar-lts branch June 6, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants