fix: Allow open-vm-tools to wait indefinitely for cloud-init to finish #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default timeout is 30s. At that point, open-vm-tools restarts the machine, interrupting the cloud-init bootstrap; the bootstrap does not run on reboot. Because kubeadm init/join runs as a cloud-init command, and can run over 5m, the timeout is not enough.
|
I built images for our VCD environment: https://github.com/mesosphere/konvoy-image-builder/actions/runs/11300000631. I verified the images with konvoy2: https://github.com/mesosphere/konvoy2/actions/runs/11300313745/job/31432960422. I saw no isseus during bootstrapping. |
supershal
approved these changes
Oct 14, 2024
|
Great finding an effective fix. |
faiq
reviewed
Oct 14, 2024
Yes, this does affect vSphere templates. However, only cloud-init is used by the bootstrap on vSphere (CAPV); open-vm-tools is only used by the bootstrap on VCD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
The default timeout is 30s. At that point, open-vm-tools restarts the machine, interrupting the cloud-init bootstrap; the bootstrap does not run on reboot.
Because kubeadm init/join runs as a cloud-init command, and can run over 5m, the timeout is not enough.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: