-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds signal handling and proper clean up #1162
Open
faiq
wants to merge
4
commits into
main
Choose a base branch
from
faiq/signal-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiq
force-pushed
the
faiq/signal-handling
branch
from
August 28, 2024 20:43
8f7a831
to
8dc7fd4
Compare
faiq
commented
Aug 30, 2024
faiq
commented
Sep 6, 2024
faiq
changed the title
fix: adds signal handling
fix: adds signal handling and proper clean up
Oct 9, 2024
faiq
force-pushed
the
faiq/signal-handling
branch
2 times, most recently
from
October 9, 2024 19:33
6ebc357
to
86f324d
Compare
faiq
force-pushed
the
faiq/signal-handling
branch
from
October 10, 2024 16:52
86f324d
to
79632ee
Compare
dlipovetsky
reviewed
Oct 11, 2024
This cleans up everything now
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
this solves removing temp directories that kib creates without signal handling the defer to clean the temporary directory we create, littering the users disk.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: