Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds signal handling and proper clean up #1162

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

faiq
Copy link
Collaborator

@faiq faiq commented Aug 28, 2024

What problem does this PR solve?:

this solves removing temp directories that kib creates without signal handling the defer to clean the temporary directory we create, littering the users disk.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added the fix label Aug 28, 2024
@faiq faiq self-assigned this Aug 28, 2024
@faiq faiq added the runs-e2e-tests runs e2e tests for GHA label Sep 6, 2024
@faiq faiq changed the title fix: adds signal handling fix: adds signal handling and proper clean up Oct 9, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 9, 2024
@faiq faiq force-pushed the faiq/signal-handling branch 2 times, most recently from 6ebc357 to 86f324d Compare October 9, 2024 19:33
@faiq
Copy link
Collaborator Author

faiq commented Oct 17, 2024

This cleans up everything now

06:00 PM  fraza @ Linux-PC1RG42G  ~/go/src/github.com/mesosphere/konvoy-image-builder  faiq/signal-handling? 
$ ./bin/konvoy-image-wrapper build aws images/ami/rhel-88.yaml  
2024/10/17 01:01:11 writing new packer configuration to work/rhel-8.8-1729126871-qajKU
2024/10/17 01:01:11 starting packer build
^Ccontext canceled
error encountered: cmd failed exit status 1

06:01 PM  fraza @ Linux-PC1RG42G  ~/go/src/github.com/mesosphere/konvoy-image-builder  ⏎ 1  faiq/signal-handling? 
$ docker ps
CONTAINER ID   IMAGE                           COMMAND                  CREATED        STATUS             PORTS     NAMES
865bc2685341   moby/buildkit:buildx-stable-1   "buildkitd --allow-i…"   2 months ago   Up About an hour             buildx_buildkit_konvoy-image-builder0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix runs-e2e-tests runs e2e tests for GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants