Upgrade to Go 1.23 #575 #579
Open
+7
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devhindo Just Added a Condition regarding Go version |
devhindo
reviewed
Jan 2, 2025
Makefile
Outdated
| @@ -121,6 +121,8 @@ test: manifests generate fmt vet ## Run tests. | |||
|
|
|||
| ##@ Build | |||
|
|
|||
| +GO_VERSION ?= 1.23 | |||
devhindo
reviewed
Jan 2, 2025
Makefile
Outdated
| @@ -121,6 +121,8 @@ test: manifests generate fmt vet ## Run tests. | |||
|
|
|||
| ##@ Build | |||
|
|
|||
| +GO_VERSION ?= 1.23 | |||
| +export GO_VERSION | |||
There was a problem hiding this comment.
this shouldn't be added as well
devhindo
approved these changes
Jan 2, 2025
Signed-off-by: Swastik Swarup Dash <[email protected]>
Swastik-Swarup-Dash
force-pushed
the
go-up
branch
from
919cc87 to
c3f1f8c
Compare
Signed-off-by: Swastik Swarup Dash <[email protected]>
|
@devhindo I think there is an Issue in Signing-off is there any alternative way to proceed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Swastik Swarup Dash [email protected]
Go 1.21 -> Go 1.23