Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added status update for to be updated instances #129

Merged

Conversation

spetzold
Copy link

ServiceInstanceReopistory is not updating/invalidating the status of instances. The open issue describes what we were facing when trying to update a successfully created instance. The status of the update will not be provided to the marketplace because the successful state is taken out of the present status.yml.

When just putting the status of the to be updated instance to "in progress", the pipeline can do its job (especially overwrite the status.yml file at the end) and the broker will report the correct status to the marketplace.

Since the instance.yml file is already being updated by the broker, updating the status.yml file does no harm.

@JohannesRudolph
Copy link
Member

Very cool, thanks for your PR. What are your thoughts on the case for service bindings as mentioned in the issue?

@MoeRT09
Copy link

MoeRT09 commented Mar 25, 2024

Very cool, thanks for your PR. What are your thoughts on the case for service bindings as mentioned in the issue?

Hey, I am working together with @spetzold.
I don't think that there is an issue for service bindings, as there is no update for service instances as per spec. So only the cases "create" and "delete" need to be handled.
On creation, the status.yml is missing -> defaults to in progress, until a status.yml file is created for the binding.
On deletion, the same logic as for deleting an instance is present (where the broker sets the status to "in progress").

@spetzold
Copy link
Author

Very cool, thanks for your PR. What are your thoughts on the case for service bindings as mentioned in the issue?

Hey @JohannesRudolph,
I agree with @MoeRT09. As per specification updates for service bindings are not allowed: You can create and delete them; The specification mentions binding rotation but this will also not update the service binding but create a new one.

This change should not cause any issues regarding service bindings.

@JohannesRudolph
Copy link
Member

Thanks @spetzold and @MoeRT09 for your contributions and input. I've added a test case and will go ahead and merge it

@JohannesRudolph JohannesRudolph added this pull request to the merge queue Jun 21, 2024
Merged via the queue into meshcloud:main with commit e724359 Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants