Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement close() functionality for meshcat viewer and zmqserver that hosts the three.js webpage #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kingjin94
Copy link

Solves #87

@kingjin94
Copy link
Author

kingjin94 commented Jun 30, 2023

Tested with:

import meshcat.visualizer
vis = meshcat.visualizer.Visualizer()
vis.close()

prior to this patch vis.close() would fail and a manual killing of vis.window.server_proc would leave various processes running with ZMQbg prefix in htop's COMM / /proc//status -> Name.

Screenshot from 2023-06-30 15-59-39

Implements closing suggest, e.g., here: https://stackoverflow.com/questions/26224179/zmq-socket-gracefully-termination-in-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant