UUID caching #114
Open
UUID caching #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 73.39% 73.97% +0.58%
==========================================
Files 11 11
Lines 1075 1099 +24
==========================================
+ Hits 789 813 +24
Misses 286 286
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pairs with meshcat js PR #115 to avoid re-sending geometry or materials with duplicate UUIDs while achieving the same visualization result.
This hopefully saves a ton of bandwidth, and also dramatically reduces static_html export size for scenes with many repeated heavy elements. For example, the attached scene with 1000 Stanford bunnies (generated by this script) serializes to ~1MB with this caching, but >100MB without.
save_with_caching.zip
Note that for this to be useful, you do have to make sure your geometries / materials are actually have the same UUID. (E.g. if you create a meshcat geometry from the same mesh data twice, that might not be true by default.)