Allow Semicolons in Timeline Titles, Sections, Periods, and Events #5335
+20
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This pull request removes the semicolons from the title, section, events, and periods regex so that semicolons can be used in their text content.
Resolves #4175. This doesn't directly address that issue, but I wanted to link it because my ultimate goal is to figure out how to allow colons without them being identified as tokens.
📏 Design Decisions
I simply removed the semicolon symbol from the exclusion clause regex for the title, section, event and period. I almost made sure to add a test to the timeline test suite and run
pnpm test
to ensure that it was still working.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch