Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust-sdk): Make API key optional for self-hosted instances #991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RutamBhagat
Copy link

@RutamBhagat RutamBhagat commented Dec 17, 2024

Fixes: #961

Description:
Modified the Rust SDK to make API keys optional for self-hosted instances while keeping them mandatory for cloud service (api.firecrawl.dev).
Added tests to verify this behavior.
This change aligns with documentation update regarding API key requirements.

@RutamBhagat RutamBhagat changed the title feat(rust-sdk): Enforce API key requirement only for cloud service feat(rust-sdk): Make API key optional for self-hosted instances Dec 18, 2024
@RutamBhagat RutamBhagat force-pushed the rust-sdk-conditionally-enforce-api-key branch from 89fb537 to 41e47eb Compare December 18, 2024 08:17
@nickscamara nickscamara requested a review from mogery December 20, 2024 00:06
@nickscamara
Copy link
Member

Assigning @mogery to review it!

@RutamBhagat RutamBhagat force-pushed the rust-sdk-conditionally-enforce-api-key branch from 41e47eb to f47e311 Compare December 20, 2024 10:04
Copy link
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Not enforce API Key to be provided in the sdks when self hosting
3 participants