Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js-sdk): Make API key optional for self-hosted instances #989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(js-sdk): Make API key optional for self-hosted instances #989

wants to merge 1 commit into from

Conversation

RutamBhagat
Copy link

@RutamBhagat RutamBhagat commented Dec 17, 2024 •
edited
Loading

Fixes: #961

Description:

  • Updates SDK to only require API key validation for cloud service (api.firecrawl.dev)
  • Allows SDK initialization without API key for self-hosted instances
  • Updates test suite to handle both cloud and self-hosted scenarios

@nickscamara nickscamara self-requested a review December 20, 2024 00:05
nickscamara
nickscamara approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@nickscamara nickscamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @RutamBhagat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickscamara nickscamara nickscamara approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Not enforce API Key to be provided in the sdks when self hosting
2 participants
@RutamBhagat @nickscamara